lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Input: cy8ctmg100_ts - signedness bug

Browse Source 
"ret" should be signed here or the error handling doesn't work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dan Carpenter
2010-08-09 10:06:47 -07:00
committed by Dmitry Torokhov
parent 22462d9fcf
commit f1b50760a7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/input/touchscreen/cy8ctmg110_ts.c
View File

@@ -75,7 +75,7 @@ static int cy8ctmg110_write_regs(struct cy8ctmg110 *tsc, unsigned char reg,
unsigned char len, unsigned char *value) unsigned char len, unsigned char *value)
{ {
struct i2c_client *client = tsc->client; struct i2c_client *client = tsc->client;
unsigned int ret; int ret;
unsigned char i2c_data[6]; unsigned char i2c_data[6];
BUG_ON(len > 5); BUG_ON(len > 5);
@@ -86,7 +86,7 @@ static int cy8ctmg110_write_regs(struct cy8ctmg110 *tsc, unsigned char reg,
ret = i2c_master_send(client, i2c_data, len + 1); ret = i2c_master_send(client, i2c_data, len + 1);
if (ret != 1) { if (ret != 1) {
dev_err(&client->dev, "i2c write data cmd failed\n"); dev_err(&client->dev, "i2c write data cmd failed\n");
return ret; return ret ? ret : -EIO;
} }
return 0; return 0;
@@ -96,7 +96,7 @@ static int cy8ctmg110_read_regs(struct cy8ctmg110 *tsc,
unsigned char *data, unsigned char len, unsigned char cmd) unsigned char *data, unsigned char len, unsigned char cmd)
{ {
struct i2c_client *client = tsc->client; struct i2c_client *client = tsc->client;
unsigned int ret; int ret;
struct i2c_msg msg[2] = { struct i2c_msg msg[2] = {
/* first write slave position to i2c devices */ /* first write slave position to i2c devices */
{ client->addr, 0, 1, &cmd }, { client->addr, 0, 1, &cmd },