lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

md: notify the 'degraded' sysfs attribute on failure.

Browse Source 
We currently only 'notify' changes to the 'degraded' attribute
when it decreases, not when it increases.

Notifying on failure is a little awkward as it happen in
interrupt context.
So instead, notify when we remove the failed device from the array,
which is very soon afterwards.

Reported-and-tested-by: Mikhail Balabin <mbalabin@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
NeilBrown
2012-01-09 00:46:41 +11:00
parent 19d671695e
commit f2a371c5e7
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/md/md.c
View File

@@ -7383,6 +7383,7 @@ static int remove_and_add_spares(struct mddev *mddev)
{ {
struct md_rdev *rdev; struct md_rdev *rdev;
int spares = 0; int spares = 0;
int removed = 0;
mddev->curr_resync_completed = 0; mddev->curr_resync_completed = 0;
@@ -7396,8 +7397,13 @@ static int remove_and_add_spares(struct mddev *mddev)
mddev, rdev) == 0) { mddev, rdev) == 0) {
sysfs_unlink_rdev(mddev, rdev); sysfs_unlink_rdev(mddev, rdev);
rdev->raid_disk = -1; rdev->raid_disk = -1;
removed++;
} }
} }
if (removed)
sysfs_notify(&mddev->kobj, NULL,
"degraded");
list_for_each_entry(rdev, &mddev->disks, same_set) { list_for_each_entry(rdev, &mddev->disks, same_set) {
if (rdev->raid_disk >= 0 && if (rdev->raid_disk >= 0 &&