lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fs: Remove bogus wait in write_inode_now()

Browse Source 
inode_sync_wait() in write_inode_now() is just bogus. That function waits for
I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return
so the wait is effectivelly a nop unless someone else submits the inode for
writeback again. All the waiting write_inode_now() needs is achieved by using
WB_SYNC_ALL writeback mode.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
This commit is contained in:
Jan Kara
2012-03-09 07:26:07 -08:00
committed by Fengguang Wu
parent 9f8050c4f9
commit f469ec9c5b
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/fs-writeback.c
View File

@@ -1364,8 +1364,6 @@ int write_inode_now(struct inode *inode, int sync)
ret = writeback_single_inode(inode, wb, &wbc); ret = writeback_single_inode(inode, wb, &wbc);
spin_unlock(&inode->i_lock); spin_unlock(&inode->i_lock);
spin_unlock(&wb->list_lock); spin_unlock(&wb->list_lock);
if (sync)
inode_sync_wait(inode);
return ret; return ret;
} }
EXPORT_SYMBOL(write_inode_now); EXPORT_SYMBOL(write_inode_now);