lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ARM] S3C24XX: Fix sparse warnings in arch/arm/plat-s3c24xx/gpiolib.c

Browse Source 
Fix the following problems spotted by sparse:

warning: symbol 's3c24xx_gpiolib_input' was not declared. Should it be static?
warning: symbol 's3c24xx_gpiolib_output' was not declared. Should it be static?
warning: symbol 's3c24xx_gpiolib_set' was not declared. Should it be static?
warning: symbol 's3c24xx_gpiolib_get' was not declared. Should it be static?
warning: symbol 'gpios' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
This commit is contained in:
Ben Dooks
2008-08-26 22:54:03 +01:00
parent ec8292347b
commit f4cb1a8964
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
arch/arm/plat-s3c24xx/gpiolib.c
View File

@@ -39,7 +39,7 @@ static inline struct s3c24xx_gpio_chip *to_s3c_chip(struct gpio_chip *gpc)
* drivers themsevles. * drivers themsevles.
*/ */
int s3c24xx_gpiolib_input(struct gpio_chip *chip, unsigned offset) static int s3c24xx_gpiolib_input(struct gpio_chip *chip, unsigned offset)
{ {
struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip); struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip);
void __iomem *base = ourchip->base; void __iomem *base = ourchip->base;
@@ -58,7 +58,7 @@ int s3c24xx_gpiolib_input(struct gpio_chip *chip, unsigned offset)
return 0; return 0;
} }
int s3c24xx_gpiolib_output(struct gpio_chip *chip, static int s3c24xx_gpiolib_output(struct gpio_chip *chip,
unsigned offset, int value) unsigned offset, int value)
{ {
struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip); struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip);
@@ -86,7 +86,8 @@ int s3c24xx_gpiolib_output(struct gpio_chip *chip,
return 0; return 0;
} }
void s3c24xx_gpiolib_set(struct gpio_chip *chip, unsigned offset, int value) static void s3c24xx_gpiolib_set(struct gpio_chip *chip,
unsigned offset, int value)
{ {
struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip); struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip);
void __iomem *base = ourchip->base; void __iomem *base = ourchip->base;
@@ -104,7 +105,7 @@ void s3c24xx_gpiolib_set(struct gpio_chip *chip, unsigned offset, int value)
local_irq_restore(flags); local_irq_restore(flags);
} }
int s3c24xx_gpiolib_get(struct gpio_chip *chip, unsigned offset) static int s3c24xx_gpiolib_get(struct gpio_chip *chip, unsigned offset)
{ {
struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip); struct s3c24xx_gpio_chip *ourchip = to_s3c_chip(chip);
unsigned long val; unsigned long val;
@@ -150,8 +151,7 @@ static int s3c24xx_gpiolib_banka_output(struct gpio_chip *chip,
return 0; return 0;
} }
static struct s3c24xx_gpio_chip gpios[] = {
struct s3c24xx_gpio_chip gpios[] = {
[0] = { [0] = {
.base = S3C24XX_GPIO_BASE(S3C2410_GPA0), .base = S3C24XX_GPIO_BASE(S3C2410_GPA0),
.chip = { .chip = {