lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Input: Add proper locking when changing device's keymap

Browse Source 
Take dev->event_lock to make sure that we don't race with input_event() and
also force key up event when removing a key from keymap table.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dmitry Torokhov
2007-11-04 00:41:12 -04:00
parent 554101e3e5
commit f4f37c8ec7
4 changed files with 80 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/input/evdev.c
View File

@ -617,7 +617,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
if (get_user(t, ip))
return -EFAULT;
error = dev->getkeycode(dev, t, &v);
error = input_get_keycode(dev, t, &v);
if (error)
return error;
@ -630,7 +630,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
if (get_user(t, ip) || get_user(v, ip + 1))
return -EFAULT;
return dev->setkeycode(dev, t, v);
return input_set_keycode(dev, t, v);
case EVIOCSFF:
if (copy_from_user(&effect, p, sizeof(effect)))
@ -683,7 +683,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
case EV_FF: bits = dev->ffbit; len = FF_MAX; break;
case EV_SW: bits = dev->swbit; len = SW_MAX; break;
default: return -EINVAL;
}
}
return bits_to_user(bits, len, _IOC_SIZE(cmd), p, compat_mode);
}