lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] radio-si470x: fix memory leak in si470x_usb_driver_probe()

Browse Source 
radio->int_in_urb is not deallocated on error paths in si470x_usb_driver_probe().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Alexey Khoroshilov
2011-05-31 17:54:40 -03:00
committed by Mauro Carvalho Chehab
parent fabc6b85ca
commit f54ba7f199
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/radio/si470x/radio-si470x-usb.c
View File

@@ -699,7 +699,7 @@ static int si470x_usb_driver_probe(struct usb_interface *intf,
radio->videodev = video_device_alloc(); radio->videodev = video_device_alloc();
if (!radio->videodev) { if (!radio->videodev) {
retval = -ENOMEM; retval = -ENOMEM;
goto err_intbuffer; goto err_urb;
} }
memcpy(radio->videodev, &si470x_viddev_template, memcpy(radio->videodev, &si470x_viddev_template,
sizeof(si470x_viddev_template)); sizeof(si470x_viddev_template));
@@ -790,6 +790,8 @@ err_all:
kfree(radio->buffer); kfree(radio->buffer);
err_video: err_video:
video_device_release(radio->videodev); video_device_release(radio->videodev);
err_urb:
usb_free_urb(radio->int_in_urb);
err_intbuffer: err_intbuffer:
kfree(radio->int_in_buffer); kfree(radio->int_in_buffer);
err_radio: err_radio: