lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

coda: clean failure exits in coda_fill_super()

Browse Source 
same as for cifs, move iput() to the right place, make it unconditional

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2012-02-12 21:15:58 -05:00
parent 064326c077
commit f56b0fbc64
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
fs/coda/inode.c
View File

@@ -208,7 +208,6 @@ static int coda_fill_super(struct super_block *sb, void *data, int silent)
if (IS_ERR(root)) { if (IS_ERR(root)) {
error = PTR_ERR(root); error = PTR_ERR(root);
printk("Failure of coda_cnode_make for root: error %d\n", error); printk("Failure of coda_cnode_make for root: error %d\n", error);
root = NULL;
goto error; goto error;
} }
@@ -216,15 +215,13 @@ static int coda_fill_super(struct super_block *sb, void *data, int silent)
root->i_ino, root->i_sb->s_id); root->i_ino, root->i_sb->s_id);
sb->s_root = d_alloc_root(root); sb->s_root = d_alloc_root(root);
if (!sb->s_root) { if (!sb->s_root) {
iput(root);
error = -EINVAL; error = -EINVAL;
goto error; goto error;
} }
return 0; return 0;
error: error:
if (root)
iput(root);
mutex_lock(&vc->vc_mutex); mutex_lock(&vc->vc_mutex);
bdi_destroy(&vc->bdi); bdi_destroy(&vc->bdi);
vc->vc_sb = NULL; vc->vc_sb = NULL;