lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

lguest: make sure cpu is initialized before accessing it

Browse Source 
If req is LHREQ_INITIALIZE, and the guest has been initialized before
(unlikely), it will attempt to access cpu->tsk even though cpu is not yet
initialized.

Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Eugene Teo
2008-02-09 23:53:17 +08:00
committed by Rusty Russell
parent cdeeeae056
commit f73d1e6ca6
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/lguest/lguest_user.c
View File

@@ -241,15 +241,16 @@ static ssize_t write(struct file *file, const char __user *in,
cpu = &lg->cpus[cpu_id]; cpu = &lg->cpus[cpu_id];
if (!cpu) if (!cpu)
return -EINVAL; return -EINVAL;
}
/* Once the Guest is dead, all you can do is read() why it died. */ /* Once the Guest is dead, you can only read() why it died. */
if (lg && lg->dead) if (lg->dead)
return -ENOENT; return -ENOENT;
/* If you're not the task which owns the Guest, you can only break */ /* If you're not the task which owns the Guest, all you can do
if (lg && current != cpu->tsk && req != LHREQ_BREAK) * is break the Launcher out of running the Guest. */
if (current != cpu->tsk && req != LHREQ_BREAK)
return -EPERM; return -EPERM;
}
switch (req) { switch (req) {
case LHREQ_INITIALIZE: case LHREQ_INITIALIZE: