lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wext: remove seq_start/stop sparse annotations

Browse Source 
Even though they are true, they cause sparse to complain
because it doesn't see the __acquires(dev_base_lock) on
dev_seq_start() because it is only added to the function
in net/core/dev.c, not the header file. To keep track of
the nesting correctly we should probably annotate those
functions publically, but for now let's just remove the
annotation I added to wext.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Johannes Berg
2009-05-12 08:36:43 +02:00
committed by John W. Linville
parent faa8fdc853
commit f7eef3563c
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/wireless/wext.c
View File

@@ -650,14 +650,12 @@ static int wireless_seq_show(struct seq_file *seq, void *v)
} }
static void *wireless_dev_seq_start(struct seq_file *seq, loff_t *pos) static void *wireless_dev_seq_start(struct seq_file *seq, loff_t *pos)
__acquires(dev_base_lock)
{ {
rtnl_lock(); rtnl_lock();
return dev_seq_start(seq, pos); return dev_seq_start(seq, pos);
} }
static void wireless_dev_seq_stop(struct seq_file *seq, void *v) static void wireless_dev_seq_stop(struct seq_file *seq, void *v)
__releases(dev_base_lock)
{ {
dev_seq_stop(seq, v); dev_seq_stop(seq, v);
rtnl_unlock(); rtnl_unlock();