lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] iscsi class: fix endpoint leak

Browse Source 
class_find_device gets a ref to the device so we must release it.
The class will serialize access to the ep so we do not have to worry
about a remove racing with the callers access, so we can simplify the
use and drop the ref right away.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
Mike Christie
2008-06-16 10:11:35 -05:00
committed by James Bottomley
parent 4c2133c823
commit f80f868ec4
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/scsi/scsi_transport_iscsi.c
View File

@@ -219,6 +219,7 @@ EXPORT_SYMBOL_GPL(iscsi_destroy_endpoint);
struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle) struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle)
{ {
struct iscsi_endpoint *ep;
struct device *dev; struct device *dev;
dev = class_find_device(&iscsi_endpoint_class, &handle, dev = class_find_device(&iscsi_endpoint_class, &handle,
@@ -226,7 +227,13 @@ struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle)
if (!dev) if (!dev)
return NULL; return NULL;
return iscsi_dev_to_endpoint(dev); ep = iscsi_dev_to_endpoint(dev);
/*
* we can drop this now because the interface will prevent
* removals and lookups from racing.
*/
put_device(dev);
return ep;
} }
EXPORT_SYMBOL_GPL(iscsi_lookup_endpoint); EXPORT_SYMBOL_GPL(iscsi_lookup_endpoint);