lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ext4: Simplify function signature for ext4_da_get_block_write()

Browse Source 
The function ext4_da_get_block_write() is called in exactly one write,
and the last argument, create, is always 1.  Remove it to simplify the
code slightly.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
This commit is contained in:
Theodore Ts'o
2009-05-12 00:21:29 -04:00
parent bc8e67409c
commit f888e652d7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/ext4/inode.c
View File

@@ -2000,7 +2000,7 @@ static void ext4_print_free_blocks(struct inode *inode)
#define EXT4_DELALLOC_RSVED 1 #define EXT4_DELALLOC_RSVED 1
static int ext4_da_get_block_write(struct inode *inode, sector_t iblock, static int ext4_da_get_block_write(struct inode *inode, sector_t iblock,
struct buffer_head *bh_result, int create) struct buffer_head *bh_result)
{ {
int ret; int ret;
unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; unsigned max_blocks = bh_result->b_size >> inode->i_blkbits;
@@ -2010,7 +2010,7 @@ static int ext4_da_get_block_write(struct inode *inode, sector_t iblock,
handle = ext4_journal_current_handle(); handle = ext4_journal_current_handle();
BUG_ON(!handle); BUG_ON(!handle);
ret = ext4_get_blocks_wrap(handle, inode, iblock, max_blocks, ret = ext4_get_blocks_wrap(handle, inode, iblock, max_blocks,
bh_result, create, 0, EXT4_DELALLOC_RSVED); bh_result, 1, 0, EXT4_DELALLOC_RSVED);
if (ret <= 0) if (ret <= 0)
return ret; return ret;
@@ -2088,7 +2088,7 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd)
if (!new.b_size) if (!new.b_size)
return 0; return 0;
err = ext4_da_get_block_write(mpd->inode, next, &new, 1); err = ext4_da_get_block_write(mpd->inode, next, &new);
if (err) { if (err) {
/* /*
* If get block returns with error we simply * If get block returns with error we simply