lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "configfs: Allow ->make_item() and ->make_group() to return detailed errors."

Browse Source 
This reverts commit 11c3b79218.  The code
will move to PTR_ERR().

Signed-off-by: Joel Becker <joel.becker@oracle.com>
This commit is contained in:
Joel Becker
2008-07-17 14:53:48 -07:00
parent 5b664cb235
commit f89ab8619e
8 changed files with 64 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/netconsole.c
View File

@@ -585,9 +585,8 @@ static struct config_item_type netconsole_target_type = {
* Group operations and type for netconsole_subsys.
*/
static int make_netconsole_target(struct config_group *group,
const char *name,
struct config_item **new_item)
static struct config_item *make_netconsole_target(struct config_group *group,
const char *name)
{
unsigned long flags;
struct netconsole_target *nt;
@@ -599,7 +598,7 @@ static int make_netconsole_target(struct config_group *group,
nt = kzalloc(sizeof(*nt), GFP_KERNEL);
if (!nt) {
printk(KERN_ERR "netconsole: failed to allocate memory\n");
return -ENOMEM;
return NULL;
}
nt->np.name = "netconsole";
@@ -616,8 +615,7 @@ static int make_netconsole_target(struct config_group *group,
list_add(&nt->list, &target_list);
spin_unlock_irqrestore(&target_list_lock, flags);
*new_item = &nt->item;
return 0;
return &nt->item;
}
static void drop_netconsole_target(struct config_group *group,