lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

inifiband: Remove BKL from ipath_open()

Browse Source 
cycle_kernel_lock() got pushed down to ipath_open(). I tried hard to
understand what it might protect, but finally gave up.

Roland noted that qlogic seems to have abandoned the ipath driver and
came to the following wise conclusion: "So I guess if the BKL stuff is
blocking you in any way, we can just drop it from ipath and leave it
as yet another race condition in a rotting old driver."

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <adad44tj090.fsf@cisco.com>
Cc: Roland Dreier <rdreier@cisco.com>
This commit is contained in:
Thomas Gleixner
2009-10-14 16:36:26 +02:00
parent d2a7be0be1
commit f96d3015e9
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/infiniband/hw/ipath/ipath_file_ops.c
View File

@@ -1821,7 +1821,6 @@ done:
static int ipath_open(struct inode *in, struct file *fp) static int ipath_open(struct inode *in, struct file *fp)
{ {
/* The real work is performed later in ipath_assign_port() */ /* The real work is performed later in ipath_assign_port() */
cycle_kernel_lock();
fp->private_data = kzalloc(sizeof(struct ipath_filedata), GFP_KERNEL); fp->private_data = kzalloc(sizeof(struct ipath_filedata), GFP_KERNEL);
return fp->private_data ? 0 : -ENOMEM; return fp->private_data ? 0 : -ENOMEM;
} }