lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: rtlxxxx: off by one in AsicSendCommandToMcu() and NDIS_STATUS NICLoadFirmware()

Browse Source 
With a postfix increment i/Index is incremented beyond 100/1000 so the
message will be displayed too soon.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Roel Kluin
2009-05-13 20:37:54 +02:00
committed by Greg Kroah-Hartman
parent 8d72f98abb
commit f991a65c0c
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/rt2860/common/mlme.c
View File

@@ -7866,7 +7866,7 @@ BOOLEAN AsicSendCommandToMcu(
RTMPusecDelay(2); RTMPusecDelay(2);
} while(i++ < 100); } while(i++ < 100);
if (i >= 100) if (i > 100)
{ {
{ {
#ifdef RT2860 #ifdef RT2860

2
drivers/staging/rt2860/common/rtmp_init.c
View File

@@ -3366,7 +3366,7 @@ NDIS_STATUS NICLoadFirmware(
RTMPusecDelay(1000); RTMPusecDelay(1000);
} while (Index++ < 1000); } while (Index++ < 1000);
if (Index >= 1000) if (Index > 1000)
{ {
Status = NDIS_STATUS_FAILURE; Status = NDIS_STATUS_FAILURE;
DBGPRINT(RT_DEBUG_ERROR, ("NICLoadFirmware: MCU is not ready\n\n\n")); DBGPRINT(RT_DEBUG_ERROR, ("NICLoadFirmware: MCU is not ready\n\n\n"));