lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ide: remove superfluous SELECT_MASK() call from ide_driveid_update()

Browse Source 
We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call
so there is no need to do it again in the error path.

Moreover with the combination of HPT36x controller and the drive on
the quirk_drives[] list this can result in superfluous enable_irq()
call which in turn will trigger WARN() in __enable_irq().

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
This commit is contained in:
Bartlomiej Zolnierkiewicz
2009-06-07 15:37:06 +02:00
parent dff8817b78
commit f9952beeaa
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/ide/ide-iops.c
View File

@@ -311,7 +311,6 @@ int ide_driveid_update(ide_drive_t *drive)
return 1; return 1;
out_err: out_err:
SELECT_MASK(drive, 0);
if (rc == 2) if (rc == 2)
printk(KERN_ERR "%s: %s: bad status\n", drive->name, __func__); printk(KERN_ERR "%s: %s: bad status\n", drive->name, __func__);
kfree(id); kfree(id);