lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ipmi: remove ->write_proc code

Browse Source 
IPMI code theoretically allows ->write_proc users, but nobody uses this thus
far.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan
2008-04-29 01:01:13 -07:00
committed by Linus Torvalds
parent 95c0ba8924
commit fa68be0def
3 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/char/ipmi/ipmi_msghandler.c
View File

@@ -1941,7 +1941,7 @@ static int stat_file_read_proc(char *page, char **start, off_t off,
#endif /* CONFIG_PROC_FS */ #endif /* CONFIG_PROC_FS */
int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name, int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
read_proc_t *read_proc, write_proc_t *write_proc, read_proc_t *read_proc,
void *data, struct module *owner) void *data, struct module *owner)
{ {
int rv = 0; int rv = 0;
@@ -1968,7 +1968,6 @@ int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
} else { } else {
file->data = data; file->data = data;
file->read_proc = read_proc; file->read_proc = read_proc;
file->write_proc = write_proc;
file->owner = owner; file->owner = owner;
mutex_lock(&smi->proc_entry_lock); mutex_lock(&smi->proc_entry_lock);
@@ -1997,17 +1996,17 @@ static int add_proc_entries(ipmi_smi_t smi, int num)
if (rv == 0) if (rv == 0)
rv = ipmi_smi_add_proc_entry(smi, "stats", rv = ipmi_smi_add_proc_entry(smi, "stats",
stat_file_read_proc, NULL, stat_file_read_proc,
smi, THIS_MODULE); smi, THIS_MODULE);
if (rv == 0) if (rv == 0)
rv = ipmi_smi_add_proc_entry(smi, "ipmb", rv = ipmi_smi_add_proc_entry(smi, "ipmb",
ipmb_file_read_proc, NULL, ipmb_file_read_proc,
smi, THIS_MODULE); smi, THIS_MODULE);
if (rv == 0) if (rv == 0)
rv = ipmi_smi_add_proc_entry(smi, "version", rv = ipmi_smi_add_proc_entry(smi, "version",
version_file_read_proc, NULL, version_file_read_proc,
smi, THIS_MODULE); smi, THIS_MODULE);
#endif /* CONFIG_PROC_FS */ #endif /* CONFIG_PROC_FS */

6
drivers/char/ipmi/ipmi_si_intf.c
View File

@@ -2892,7 +2892,7 @@ static int try_smi_init(struct smi_info *new_smi)
} }
rv = ipmi_smi_add_proc_entry(new_smi->intf, "type", rv = ipmi_smi_add_proc_entry(new_smi->intf, "type",
type_file_read_proc, NULL, type_file_read_proc,
new_smi, THIS_MODULE); new_smi, THIS_MODULE);
if (rv) { if (rv) {
printk(KERN_ERR printk(KERN_ERR
@@ -2902,7 +2902,7 @@ static int try_smi_init(struct smi_info *new_smi)
} }
rv = ipmi_smi_add_proc_entry(new_smi->intf, "si_stats", rv = ipmi_smi_add_proc_entry(new_smi->intf, "si_stats",
stat_file_read_proc, NULL, stat_file_read_proc,
new_smi, THIS_MODULE); new_smi, THIS_MODULE);
if (rv) { if (rv) {
printk(KERN_ERR printk(KERN_ERR
@@ -2912,7 +2912,7 @@ static int try_smi_init(struct smi_info *new_smi)
} }
rv = ipmi_smi_add_proc_entry(new_smi->intf, "params", rv = ipmi_smi_add_proc_entry(new_smi->intf, "params",
param_read_proc, NULL, param_read_proc,
new_smi, THIS_MODULE); new_smi, THIS_MODULE);
if (rv) { if (rv) {
printk(KERN_ERR printk(KERN_ERR

2
include/linux/ipmi_smi.h
View File

@@ -229,7 +229,7 @@ static inline void ipmi_free_smi_msg(struct ipmi_smi_msg *msg)
directory for this interface. Note that the entry will directory for this interface. Note that the entry will
automatically be dstroyed when the interface is destroyed. */ automatically be dstroyed when the interface is destroyed. */
int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name, int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
read_proc_t *read_proc, write_proc_t *write_proc, read_proc_t *read_proc,
void *data, struct module *owner); void *data, struct module *owner);
#endif /* __LINUX_IPMI_SMI_H */ #endif /* __LINUX_IPMI_SMI_H */