lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: memory leak in iowarrior.c

Browse Source 
this is a classical memory leak in the ioctl handler. The buffer is simply
never freed. This fixes it the obvious way.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Oliver Neukum
2007-06-12 15:36:07 +02:00
committed by Greg Kroah-Hartman
parent 944dc184f6
commit fc0f8fc9be
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/usb/misc/iowarrior.c
View File

@@ -495,8 +495,8 @@ static int iowarrior_ioctl(struct inode *inode, struct file *file,
/* verify that the device wasn't unplugged */ /* verify that the device wasn't unplugged */
if (!dev->present) { if (!dev->present) {
mutex_unlock(&dev->mutex); retval = -ENODEV;
return -ENODEV; goto error_out;
} }
dbg("%s - minor %d, cmd 0x%.4x, arg %ld", __func__, dev->minor, cmd, dbg("%s - minor %d, cmd 0x%.4x, arg %ld", __func__, dev->minor, cmd,
@@ -579,9 +579,10 @@ static int iowarrior_ioctl(struct inode *inode, struct file *file,
retval = -ENOTTY; retval = -ENOTTY;
break; break;
} }
error_out:
/* unlock the device */ /* unlock the device */
mutex_unlock(&dev->mutex); mutex_unlock(&dev->mutex);
kfree(buffer);
return retval; return retval;
} }