lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sysfs_notify is only possible on file attributes

Browse Source 
If sysfs_notify is called on a binary attribute, bad things can
happen, so prevent it.

Note, no in-kernel usage of this is currently present, but in the
future, it's good to be safe.

Changes in V2:
- Also ignore sysfs_notify on dirs, links
- Use WARN_ON rather than silently failing
- Compiled and tested (huge apologies about first submission)

Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nick Dyer
2013-06-07 15:45:13 +01:00
committed by Greg Kroah-Hartman
parent d6c8aa3906
commit fc60bb8339
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/sysfs/file.c
View File

@@ -449,11 +449,13 @@ void sysfs_notify_dirent(struct sysfs_dirent *sd)
spin_lock_irqsave(&sysfs_open_dirent_lock, flags); spin_lock_irqsave(&sysfs_open_dirent_lock, flags);
if (!WARN_ON(sysfs_type(sd) != SYSFS_KOBJ_ATTR)) {
od = sd->s_attr.open; od = sd->s_attr.open;
if (od) { if (od) {
atomic_inc(&od->event); atomic_inc(&od->event);
wake_up_interruptible(&od->poll); wake_up_interruptible(&od->poll);
} }
}
spin_unlock_irqrestore(&sysfs_open_dirent_lock, flags); spin_unlock_irqrestore(&sysfs_open_dirent_lock, flags);
} }