lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drm/radeon/kms: Fix NULL pointer dereference if memory allocation failed.

Browse Source 
When there is allocation failure in radeon_cs_parser_relocs parser->nrelocs
is not cleaned. This causes NULL pointer defeference in radeon_cs_parser_fini
when clean up code is trying to loop over the relocation array and free the
objects.

Fix adds a check for a possible NULL pointer in clean up code.

Signed-off-by: Pauli Nieminen <suokkos@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Pauli Nieminen 2010-03-19 07:44:33 +00:00 committed by Dave Airlie
parent f927456202
commit fcbc451ba1
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/radeon/radeon_cs.c
View File

@ -193,9 +193,11 @@ static void radeon_cs_parser_fini(struct radeon_cs_parser *parser, int error)
radeon_bo_list_fence(&parser->validated, parser->ib->fence); radeon_bo_list_fence(&parser->validated, parser->ib->fence);
} }
radeon_bo_list_unreserve(&parser->validated); radeon_bo_list_unreserve(&parser->validated);
for (i = 0; i < parser->nrelocs; i++) { if (parser->relocs != NULL) {
if (parser->relocs[i].gobj) for (i = 0; i < parser->nrelocs; i++) {
drm_gem_object_unreference_unlocked(parser->relocs[i].gobj); if (parser->relocs[i].gobj)
drm_gem_object_unreference_unlocked(parser->relocs[i].gobj);
}
} }
kfree(parser->track); kfree(parser->track);
kfree(parser->relocs); kfree(parser->relocs);