lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] Char: stallion, prints cleanup

Browse Source 
Too many information is printed out (they may be easily obtained through
sysfs), wipe them out in probe function.  Convert rest of them to dev_
variants.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jiri Slaby
2006-12-08 02:39:09 -08:00
committed by Linus Torvalds
parent b1b84fe0d7
commit fefaf9a789
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/char/stallion.c
View File

@@ -2421,9 +2421,6 @@ static int __devinit stl_pciprobe(struct pci_dev *pdev,
struct stlbrd *brdp; struct stlbrd *brdp;
unsigned int brdtype = ent->driver_data; unsigned int brdtype = ent->driver_data;
pr_debug("stl_initpcibrd(brdtype=%d,busnr=%x,devnr=%x)\n", brdtype,
pdev->bus->number, pdev->devfn);
if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE)
return -ENODEV; return -ENODEV;
@@ -2435,20 +2432,12 @@ static int __devinit stl_pciprobe(struct pci_dev *pdev,
if ((brdp = stl_allocbrd()) == NULL) if ((brdp = stl_allocbrd()) == NULL)
return(-ENOMEM); return(-ENOMEM);
if ((brdp->brdnr = stl_getbrdnr()) < 0) { if ((brdp->brdnr = stl_getbrdnr()) < 0) {
printk("STALLION: too many boards found, " dev_err(&pdev->dev, "too many boards found, "
"maximum supported %d\n", STL_MAXBRDS); "maximum supported %d\n", STL_MAXBRDS);
return(0); return(0);
} }
brdp->brdtype = brdtype; brdp->brdtype = brdtype;
/*
* Different Stallion boards use the BAR registers in different ways,
* so set up io addresses based on board type.
*/
pr_debug("%s(%d): BAR[]=%Lx,%Lx,%Lx,%Lx IRQ=%x\n", __FILE__, __LINE__,
pci_resource_start(pdev, 0), pci_resource_start(pdev, 1),
pci_resource_start(pdev, 2), pci_resource_start(pdev, 3), pdev->irq);
/* /*
* We have all resources from the board, so let's setup the actual * We have all resources from the board, so let's setup the actual
* board structure now. * board structure now.
@@ -2467,7 +2456,7 @@ static int __devinit stl_pciprobe(struct pci_dev *pdev,
brdp->ioaddr2 = pci_resource_start(pdev, 1); brdp->ioaddr2 = pci_resource_start(pdev, 1);
break; break;
default: default:
printk("STALLION: unknown PCI board type=%d\n", brdtype); dev_err(&pdev->dev, "unknown PCI board type=%u\n", brdtype);
break; break;
} }