lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/net/wireless/iwmc3200wifi: Use kmemdup

Browse Source 
Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Julia Lawall
2010-05-15 23:16:58 +02:00
committed by John W. Linville
parent 0273002953
commit ff020726a7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/iwmc3200wifi/rx.c
View File

@@ -321,14 +321,14 @@ iwm_rx_ticket_node_alloc(struct iwm_priv *iwm, struct iwm_rx_ticket *ticket)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }
ticket_node->ticket = kzalloc(sizeof(struct iwm_rx_ticket), GFP_KERNEL); ticket_node->ticket = kmemdup(ticket, sizeof(struct iwm_rx_ticket),
GFP_KERNEL);
if (!ticket_node->ticket) { if (!ticket_node->ticket) {
IWM_ERR(iwm, "Couldn't allocate RX ticket\n"); IWM_ERR(iwm, "Couldn't allocate RX ticket\n");
kfree(ticket_node); kfree(ticket_node);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }
memcpy(ticket_node->ticket, ticket, sizeof(struct iwm_rx_ticket));
INIT_LIST_HEAD(&ticket_node->node); INIT_LIST_HEAD(&ticket_node->node);
return ticket_node; return ticket_node;