lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl

Browse Source 
Based on report and patch by Doug Kehn <rdkehn@yahoo.com>:

vconfig returns the following error when attempting to execute the
set_ingress_map command:

vconfig: socket or ioctl error for set_ingress_map: Operation not permitted

In vlan.c, vlan_ioctl_handler for SET_VLAN_INGRESS_PRIORITY_CMD
sets err = -EPERM and calls vlan_dev_set_ingress_priority.
vlan_dev_set_ingress_priority is a void function so err remains
at -EPERM and results in the vconfig error (even though the ingress
map was set).

Fix by setting err = 0 after the vlan_dev_set_ingress_priority call.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Patrick McHardy
2007-11-07 01:31:32 -08:00
committed by David S. Miller
parent 45a19b0a72
commit fffe470a80
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
net/8021q/vlan.c
View File

@@ -747,6 +747,7 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg)
vlan_dev_set_ingress_priority(dev, vlan_dev_set_ingress_priority(dev,
args.u.skb_priority, args.u.skb_priority,
args.vlan_qos); args.vlan_qos);
err = 0;
break; break;
case SET_VLAN_EGRESS_PRIORITY_CMD: case SET_VLAN_EGRESS_PRIORITY_CMD: