Fernando Luis Vazquez Cao 6049f2530c rtnetlink: fix oops in rtnl_link_get_slave_info_data_size ... We should check whether rtnetlink link operations are defined before calling get_slave_size(). Without this, the following oops can occur when adding a tap device to OVS. [ 87.839553] BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 [ 87.839595] IP: [<ffffffff813d47c0>] if_nlmsg_size+0xf0/0x220 [...] [ 87.840651] Call Trace: [ 87.840664] [<ffffffff813d694b>] ? rtmsg_ifinfo+0x2b/0x100 [ 87.840688] [<ffffffff813c8340>] ? __netdev_adjacent_dev_insert+0x150/0x1a0 [ 87.840718] [<ffffffff813d6a50>] ? rtnetlink_event+0x30/0x40 [ 87.840742] [<ffffffff814b4144>] ? notifier_call_chain+0x44/0x70 [ 87.840768] [<ffffffff813c8946>] ? __netdev_upper_dev_link+0x3c6/0x3f0 [ 87.840798] [<ffffffffa0678d6c>] ? netdev_create+0xcc/0x160 [openvswitch] [ 87.840828] [<ffffffffa06781ea>] ? ovs_vport_add+0x4a/0xd0 [openvswitch] [ 87.840857] [<ffffffffa0670139>] ? new_vport+0x9/0x50 [openvswitch] [ 87.840884] [<ffffffffa067279e>] ? ovs_vport_cmd_new+0x11e/0x210 [openvswitch] [ 87.840915] [<ffffffff813f3efa>] ? genl_family_rcv_msg+0x19a/0x360 [ 87.840941] [<ffffffff813f40c0>] ? genl_family_rcv_msg+0x360/0x360 [ 87.840967] [<ffffffff813f4139>] ? genl_rcv_msg+0x79/0xc0 [ 87.840991] [<ffffffff813b6cf9>] ? __kmalloc_reserve.isra.25+0x29/0x80 [ 87.841018] [<ffffffff813f2389>] ? netlink_rcv_skb+0xa9/0xc0 [ 87.841042] [<ffffffff813f27cf>] ? genl_rcv+0x1f/0x30 [ 87.841064] [<ffffffff813f1988>] ? netlink_unicast+0xe8/0x1e0 [ 87.841088] [<ffffffff813f1d9a>] ? netlink_sendmsg+0x31a/0x750 [ 87.841113] [<ffffffff813aee96>] ? sock_sendmsg+0x86/0xc0 [ 87.841136] [<ffffffff813c960d>] ? __netdev_update_features+0x4d/0x200 [ 87.841163] [<ffffffff813ca94e>] ? ethtool_get_value+0x2e/0x50 [ 87.841188] [<ffffffff813af269>] ? ___sys_sendmsg+0x359/0x370 [ 87.841212] [<ffffffff813da686>] ? dev_ioctl+0x1a6/0x5c0 [ 87.841236] [<ffffffff8109c210>] ? autoremove_wake_function+0x30/0x30 [ 87.841264] [<ffffffff813ac59d>] ? sock_do_ioctl+0x3d/0x50 [ 87.841288] [<ffffffff813aca68>] ? sock_ioctl+0x1e8/0x2c0 [ 87.841312] [<ffffffff811934bf>] ? do_vfs_ioctl+0x2cf/0x4b0 [ 87.841335] [<ffffffff813afeb9>] ? __sys_sendmsg+0x39/0x70 [ 87.841362] [<ffffffff814b86f9>] ? system_call_fastpath+0x16/0x1b [ 87.841386] Code: c0 74 10 48 89 ef ff d0 83 c0 07 83 e0 fc 48 98 49 01 c7 48 89 ef e8 d0 d6 fe ff 48 85 c0 0f 84 df 00 00 00 48 8b 90 08 07 00 00 <48> 8b 8a a8 00 00 00 31 d2 48 85 c9 74 0c 48 89 ee 48 89 c7 ff [ 87.841529] RIP [<ffffffff813d47c0>] if_nlmsg_size+0xf0/0x220 [ 87.841555] RSP <ffff880221aa5950> [ 87.841569] CR2: 00000000000000a8 [ 87.851442] ---[ end trace e42ab217691b4fc2 ]--- Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> Acked-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>		2014-02-04 20:28:51 -08:00
..
datagram.c	net, datagram: fix the incorrect comment in zerocopy_sg_from_iovec()	2013-10-29 00:19:04 -04:00
dev_addr_lists.c	net: Correctly sync addresses from multiple sources to single device	2014-01-23 13:06:34 -08:00
dev_ioctl.c	net_tstamp: Add SIOCGHWTSTAMP ioctl to match SIOCSHWTSTAMP	2013-11-19 19:07:21 +00:00
dev.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
drop_monitor.c	net: drop_monitor: fix the value of maxattr	2013-12-09 21:10:38 -05:00
dst.c	net: pass info struct via netdevice notifier	2013-05-28 13:11:01 -07:00
ethtool.c	net: Add layer 2 hardware acceleration operations for macvlan devices	2013-11-07 19:11:41 -05:00
fib_rules.c	net: Fix "ip rule delete table 256"	2013-11-08 14:53:10 -05:00
filter.c	bpf: do not use reciprocal divide	2014-01-15 17:02:08 -08:00
flow_dissector.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-01-14 14:42:42 -08:00
flow.c	net: delete __cpuinit usage from all net files	2013-07-14 19:36:58 -04:00
gen_estimator.c	net_sched: add 64bit rate estimators	2013-06-11 02:51:03 -07:00
gen_stats.c	net_sched: add 64bit rate estimators	2013-06-11 02:51:03 -07:00
iovec.c	net: rework recvmsg handler msg_name and msg_namelen logic	2013-11-20 21:52:30 -05:00
link_watch.c	net: make all team port device link events urgent	2013-06-13 02:31:41 -07:00
Makefile	net: netprio: rename config to be more consistent with cgroup configs	2014-01-03 23:41:42 +01:00
neighbour.c	net/neighbour: queue work on power efficient wq	2014-01-22 21:57:05 -08:00
net_namespace.c	userns: Kill nsown_capable it makes the wrong thing easy	2013-08-30 23:44:11 -07:00
net-procfs.c	rps: selective flow shedding during softnet overflow	2013-05-20 13:48:04 -07:00
net-sysfs.c	net: fix "queues" uevent between network namespaces	2014-01-19 20:02:02 -08:00
net-sysfs.h	net: netdev_kobject_init: annotate with __init	2014-01-05 20:27:54 -05:00
net-traces.c
netclassid_cgroup.c	net: net_cls: move cgroupfs classid handling into core	2014-01-03 23:41:41 +01:00
netevent.c
netpoll.c	netpoll: Use ether_addr_copy	2014-01-21 18:13:05 -08:00
netprio_cgroup.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
pktgen.c	pktgen: Use ether_addr_copy	2014-01-21 18:13:05 -08:00
request_sock.c	tcp: fix a panic on UP machines in reqsk_fastopen_remove	2013-01-14 18:10:05 -05:00
rtnetlink.c	rtnetlink: fix oops in rtnl_link_get_slave_info_data_size	2014-02-04 20:28:51 -08:00
scm.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2013-09-07 14:35:32 -07:00
secure_seq.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-10-23 16:49:34 -04:00
skbuff.c	net: Fix warning on make htmldocs caused by skbuff.c	2014-01-28 18:06:06 -08:00
sock_diag.c	sock_diag: fix filter code sent to userspace	2013-06-10 22:23:32 -07:00
sock.c	net: introduce SO_BPF_EXTENSIONS	2014-01-18 19:08:58 -08:00
stream.c	net: replace macros net_random and net_srandom with direct calls to prandom	2014-01-14 15:15:25 -08:00
sysctl_net_core.c	rps: NUMA flow limit allocations	2013-12-19 19:00:07 -05:00
timestamping.c
user_dma.c
utils.c	net: make net_get_random_once irq safe	2013-10-25 19:03:39 -04:00