a8f492c6ac
Mixing of normal and irq spinlocks results in the following lockdep messages on bootup on IP32: [...] Sending DHCP requests . ====================================================== [ INFO: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected ] 2.6.30-rc5-00164-g41baeef #30 ------------------------------------------------------ swapper/1 [HC0[0]:SC0[1]:HE0:SE0] is trying to acquire: (&priv->meth_lock){+.+...}, at: [<ffffffff8026388c>] meth_tx+0x48/0x43c and this task is already holding: (_xmit_ETHER#2){+.-...}, at: [<ffffffff802d3a00>] __qdisc_run+0x118/0x30c which would create a new lock dependency: (_xmit_ETHER#2){+.-...} -> (&priv->meth_lock){+.+...} but this new dependency connects a SOFTIRQ-irq-safe lock: (_xmit_ETHER#2){+.-...} ... which became SOFTIRQ-irq-safe at: [<ffffffff80061458>] __lock_acquire+0x784/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff802d2b88>] dev_watchdog+0x70/0x398 [<ffffffff800433b8>] run_timer_softirq+0x1a8/0x248 [<ffffffff8003da5c>] __do_softirq+0xec/0x208 [<ffffffff8003dbd8>] do_softirq+0x60/0xe4 [<ffffffff8003dda0>] irq_exit+0x54/0x9c [<ffffffff80004420>] ret_from_irq+0x0/0x4 [<ffffffff80004720>] r4k_wait+0x20/0x40 [<ffffffff80015418>] cpu_idle+0x30/0x60 [<ffffffff804cd934>] start_kernel+0x3ec/0x404 to a SOFTIRQ-irq-unsafe lock: (&priv->meth_lock){+.+...} ... which became SOFTIRQ-irq-unsafe at: ... [<ffffffff800614f8>] __lock_acquire+0x824/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff80263f20>] meth_reset+0x118/0x2d8 [<ffffffff8026424c>] meth_open+0x28/0x140 [<ffffffff802c1ae8>] dev_open+0xe0/0x18c [<ffffffff802c1268>] dev_change_flags+0xd8/0x1d4 [<ffffffff804e7770>] ip_auto_config+0x1d4/0xf28 [<ffffffff80012e68>] do_one_initcall+0x58/0x170 [<ffffffff804cd190>] kernel_init+0x98/0x104 [<ffffffff8001520c>] kernel_thread_helper+0x10/0x18 other info that might help us debug this: 2 locks held by swapper/1: #0: (rcu_read_lock){.+.+..}, at: [<ffffffff802c0954>] dev_queue_xmit+0x1e0/0x4b0 #1: (_xmit_ETHER#2){+.-...}, at: [<ffffffff802d3a00>] __qdisc_run+0x118/0x30c the SOFTIRQ-irq-safe lock's dependencies: -> (_xmit_ETHER#2){+.-...} ops: 0 { HARDIRQ-ON-W at: [<ffffffff800614d0>] __lock_acquire+0x7fc/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff802d2b88>] dev_watchdog+0x70/0x398 [<ffffffff800433b8>] run_timer_softirq+0x1a8/0x248 [<ffffffff8003da5c>] __do_softirq+0xec/0x208 [<ffffffff8003dbd8>] do_softirq+0x60/0xe4 [<ffffffff8003dda0>] irq_exit+0x54/0x9c [<ffffffff80004420>] ret_from_irq+0x0/0x4 [<ffffffff80004720>] r4k_wait+0x20/0x40 [<ffffffff80015418>] cpu_idle+0x30/0x60 [<ffffffff804cd934>] start_kernel+0x3ec/0x404 IN-SOFTIRQ-W at: [<ffffffff80061458>] __lock_acquire+0x784/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff802d2b88>] dev_watchdog+0x70/0x398 [<ffffffff800433b8>] run_timer_softirq+0x1a8/0x248 [<ffffffff8003da5c>] __do_softirq+0xec/0x208 [<ffffffff8003dbd8>] do_softirq+0x60/0xe4 [<ffffffff8003dda0>] irq_exit+0x54/0x9c [<ffffffff80004420>] ret_from_irq+0x0/0x4 [<ffffffff80004720>] r4k_wait+0x20/0x40 [<ffffffff80015418>] cpu_idle+0x30/0x60 [<ffffffff804cd934>] start_kernel+0x3ec/0x404 INITIAL USE at: [<ffffffff80061570>] __lock_acquire+0x89c/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff802d2b88>] dev_watchdog+0x70/0x398 [<ffffffff800433b8>] run_timer_softirq+0x1a8/0x248 [<ffffffff8003da5c>] __do_softirq+0xec/0x208 [<ffffffff8003dbd8>] do_softirq+0x60/0xe4 [<ffffffff8003dda0>] irq_exit+0x54/0x9c [<ffffffff80004420>] ret_from_irq+0x0/0x4 [<ffffffff80004720>] r4k_wait+0x20/0x40 [<ffffffff80015418>] cpu_idle+0x30/0x60 [<ffffffff804cd934>] start_kernel+0x3ec/0x404 } ... key at: [<ffffffff80cf93f0>] netdev_xmit_lock_key+0x8/0x1c8 the SOFTIRQ-irq-unsafe lock's dependencies: -> (&priv->meth_lock){+.+...} ops: 0 { HARDIRQ-ON-W at: [<ffffffff800614d0>] __lock_acquire+0x7fc/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff80263f20>] meth_reset+0x118/0x2d8 [<ffffffff8026424c>] meth_open+0x28/0x140 [<ffffffff802c1ae8>] dev_open+0xe0/0x18c [<ffffffff802c1268>] dev_change_flags+0xd8/0x1d4 [<ffffffff804e7770>] ip_auto_config+0x1d4/0xf28 [<ffffffff80012e68>] do_one_initcall+0x58/0x170 [<ffffffff804cd190>] kernel_init+0x98/0x104 [<ffffffff8001520c>] kernel_thread_helper+0x10/0x18 SOFTIRQ-ON-W at: [<ffffffff800614f8>] __lock_acquire+0x824/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff80263f20>] meth_reset+0x118/0x2d8 [<ffffffff8026424c>] meth_open+0x28/0x140 [<ffffffff802c1ae8>] dev_open+0xe0/0x18c [<ffffffff802c1268>] dev_change_flags+0xd8/0x1d4 [<ffffffff804e7770>] ip_auto_config+0x1d4/0xf28 [<ffffffff80012e68>] do_one_initcall+0x58/0x170 [<ffffffff804cd190>] kernel_init+0x98/0x104 [<ffffffff8001520c>] kernel_thread_helper+0x10/0x18 INITIAL USE at: [<ffffffff80061570>] __lock_acquire+0x89c/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff800128d0>] _spin_lock+0x30/0x44 [<ffffffff80263f20>] meth_reset+0x118/0x2d8 [<ffffffff8026424c>] meth_open+0x28/0x140 [<ffffffff802c1ae8>] dev_open+0xe0/0x18c [<ffffffff802c1268>] dev_change_flags+0xd8/0x1d4 [<ffffffff804e7770>] ip_auto_config+0x1d4/0xf28 [<ffffffff80012e68>] do_one_initcall+0x58/0x170 [<ffffffff804cd190>] kernel_init+0x98/0x104 [<ffffffff8001520c>] kernel_thread_helper+0x10/0x18 } ... key at: [<ffffffff80cf6ce8>] __key.32424+0x0/0x8 stack backtrace: Call Trace: [<ffffffff8000ed0c>] dump_stack+0x8/0x34 [<ffffffff80060b74>] check_usage+0x470/0x4a0 [<ffffffff80060c34>] check_irq_usage+0x90/0x130 [<ffffffff80061f78>] __lock_acquire+0x12a4/0x1a14 [<ffffffff800627e0>] lock_acquire+0xf8/0x150 [<ffffffff80012a0c>] _spin_lock_irqsave+0x60/0x84 [<ffffffff8026388c>] meth_tx+0x48/0x43c [<ffffffff802d3a38>] __qdisc_run+0x150/0x30c [<ffffffff802c0aa8>] dev_queue_xmit+0x334/0x4b0 [<ffffffff804e7e6c>] ip_auto_config+0x8d0/0xf28 [<ffffffff80012e68>] do_one_initcall+0x58/0x170 [<ffffffff804cd190>] kernel_init+0x98/0x104 [<ffffffff8001520c>] kernel_thread_helper+0x10/0x18 ..... timed out! IP-Config: Retrying forever (NFS root)... Sending DHCP requests ., OK [...] Fixed by converting all locks to irq locks. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Tested-by: Andrew Randrianasulu <randrik_a@yahoo.com> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
---|---|---|
.. | ||
appletalk | ||
arcnet | ||
arm | ||
atl1c | ||
atl1e | ||
atlx | ||
benet | ||
bonding | ||
can | ||
chelsio | ||
cris | ||
cxgb3 | ||
e1000 | ||
e1000e | ||
ehea | ||
enic | ||
fs_enet | ||
hamradio | ||
ibm_newemac | ||
igb | ||
igbvf | ||
irda | ||
ixgb | ||
ixgbe | ||
ixp2000 | ||
mlx4 | ||
myri10ge | ||
netxen | ||
pcmcia | ||
phy | ||
qlge | ||
sfc | ||
skfp | ||
tokenring | ||
tulip | ||
usb | ||
vxge | ||
wan | ||
wimax | ||
wireless | ||
3c59x.c | ||
3c501.c | ||
3c501.h | ||
3c503.c | ||
3c503.h | ||
3c505.c | ||
3c505.h | ||
3c507.c | ||
3c509.c | ||
3c515.c | ||
3c523.c | ||
3c523.h | ||
3c527.c | ||
3c527.h | ||
7990.c | ||
7990.h | ||
8139cp.c | ||
8139too.c | ||
8390.c | ||
8390.h | ||
8390p.c | ||
82596.c | ||
a2065.c | ||
a2065.h | ||
ac3200.c | ||
acenic.c | ||
acenic.h | ||
amd8111e.c | ||
amd8111e.h | ||
apne.c | ||
ariadne.c | ||
ariadne.h | ||
at1700.c | ||
atarilance.c | ||
atp.c | ||
atp.h | ||
au1000_eth.c | ||
au1000_eth.h | ||
ax88796.c | ||
b44.c | ||
b44.h | ||
bfin_mac.c | ||
bfin_mac.h | ||
bmac.c | ||
bmac.h | ||
bnx2_fw.h | ||
bnx2.c | ||
bnx2.h | ||
bnx2x_dump.h | ||
bnx2x_fw_defs.h | ||
bnx2x_hsi.h | ||
bnx2x_init_values.h | ||
bnx2x_init.h | ||
bnx2x_link.c | ||
bnx2x_link.h | ||
bnx2x_main.c | ||
bnx2x_reg.h | ||
bnx2x.h | ||
bsd_comp.c | ||
cassini.c | ||
cassini.h | ||
cpmac.c | ||
cs89x0.c | ||
cs89x0.h | ||
de600.c | ||
de600.h | ||
de620.c | ||
de620.h | ||
declance.c | ||
defxx.c | ||
defxx.h | ||
depca.c | ||
depca.h | ||
dl2k.c | ||
dl2k.h | ||
dm9000.c | ||
dm9000.h | ||
dnet.c | ||
dnet.h | ||
dummy.c | ||
e100.c | ||
e2100.c | ||
eepro.c | ||
eexpress.c | ||
eexpress.h | ||
enc28j60_hw.h | ||
enc28j60.c | ||
epic100.c | ||
eql.c | ||
es3210.c | ||
eth16i.c | ||
ethoc.c | ||
ewrk3.c | ||
ewrk3.h | ||
fealnx.c | ||
fec_mpc52xx_phy.c | ||
fec_mpc52xx.c | ||
fec_mpc52xx.h | ||
fec.c | ||
fec.h | ||
forcedeth.c | ||
fsl_pq_mdio.c | ||
fsl_pq_mdio.h | ||
gianfar_ethtool.c | ||
gianfar_sysfs.c | ||
gianfar.c | ||
gianfar.h | ||
hamachi.c | ||
hp100.c | ||
hp100.h | ||
hp-plus.c | ||
hp.c | ||
hplance.c | ||
hplance.h | ||
hydra.c | ||
ibmlana.c | ||
ibmlana.h | ||
ibmveth.c | ||
ibmveth.h | ||
ifb.c | ||
ioc3-eth.c | ||
ipg.c | ||
ipg.h | ||
isa-skeleton.c | ||
iseries_veth.c | ||
jazzsonic.c | ||
jme.c | ||
jme.h | ||
Kconfig | ||
korina.c | ||
lance.c | ||
lasi_82596.c | ||
lib8390.c | ||
lib82596.c | ||
LICENSE.SRC | ||
lne390.c | ||
loopback.c | ||
lp486e.c | ||
mac89x0.c | ||
mac8390.c | ||
macb.c | ||
macb.h | ||
mace.c | ||
mace.h | ||
macmace.c | ||
macsonic.c | ||
macvlan.c | ||
Makefile | ||
meth.c | ||
meth.h | ||
mii.c | ||
mipsnet.c | ||
mv643xx_eth.c | ||
mvme147.c | ||
myri_sbus.c | ||
myri_sbus.h | ||
natsemi.c | ||
ne2.c | ||
ne2k-pci.c | ||
ne3210.c | ||
ne-h8300.c | ||
ne.c | ||
netconsole.c | ||
netx-eth.c | ||
ni52.c | ||
ni52.h | ||
ni65.c | ||
ni65.h | ||
ni5010.c | ||
ni5010.h | ||
niu.c | ||
niu.h | ||
ns83820.c | ||
pasemi_mac_ethtool.c | ||
pasemi_mac.c | ||
pasemi_mac.h | ||
pci-skeleton.c | ||
pcnet32.c | ||
plip.c | ||
ppp_async.c | ||
ppp_deflate.c | ||
ppp_generic.c | ||
ppp_mppe.c | ||
ppp_mppe.h | ||
ppp_synctty.c | ||
pppoe.c | ||
pppol2tp.c | ||
pppox.c | ||
ps3_gelic_net.c | ||
ps3_gelic_net.h | ||
ps3_gelic_wireless.c | ||
ps3_gelic_wireless.h | ||
qla3xxx.c | ||
qla3xxx.h | ||
r6040.c | ||
r8169.c | ||
rionet.c | ||
rrunner.c | ||
rrunner.h | ||
s2io-regs.h | ||
s2io.c | ||
s2io.h | ||
sb1000.c | ||
sb1250-mac.c | ||
sc92031.c | ||
seeq8005.c | ||
seeq8005.h | ||
sgiseeq.c | ||
sgiseeq.h | ||
sh_eth.c | ||
sh_eth.h | ||
sis190.c | ||
sis900.c | ||
sis900.h | ||
skge.c | ||
skge.h | ||
sky2.c | ||
sky2.h | ||
slhc.c | ||
slip.c | ||
slip.h | ||
smc91x.c | ||
smc91x.h | ||
smc911x.c | ||
smc911x.h | ||
smc9194.c | ||
smc9194.h | ||
smc-mca.c | ||
smc-ultra32.c | ||
smc-ultra.c | ||
smsc911x.c | ||
smsc911x.h | ||
smsc9420.c | ||
smsc9420.h | ||
sni_82596.c | ||
sonic.c | ||
sonic.h | ||
Space.c | ||
spider_net_ethtool.c | ||
spider_net.c | ||
spider_net.h | ||
starfire.c | ||
stnic.c | ||
sun3_82586.c | ||
sun3_82586.h | ||
sun3lance.c | ||
sunbmac.c | ||
sunbmac.h | ||
sundance.c | ||
sungem_phy.c | ||
sungem_phy.h | ||
sungem.c | ||
sungem.h | ||
sunhme.c | ||
sunhme.h | ||
sunlance.c | ||
sunqe.c | ||
sunqe.h | ||
sunvnet.c | ||
sunvnet.h | ||
tc35815.c | ||
tehuti.c | ||
tehuti.h | ||
tg3.c | ||
tg3.h | ||
tlan.c | ||
tlan.h | ||
tsi108_eth.c | ||
tsi108_eth.h | ||
tun.c | ||
typhoon.c | ||
typhoon.h | ||
ucc_geth_ethtool.c | ||
ucc_geth.c | ||
ucc_geth.h | ||
veth.c | ||
via-rhine.c | ||
via-velocity.c | ||
via-velocity.h | ||
virtio_net.c | ||
wd.c | ||
xen-netfront.c | ||
xtsonic.c | ||
yellowfin.c | ||
znet.c | ||
zorro8390.c |