c36fca52f5
Fixes a bug where the nfs_client could be freed during callback processing. Refactor nfs_find_client to use minorversion specific means to locate the correct nfs_client structure. In the NFS layer, V4.0 clients are found using the callback_ident field in the CB_COMPOUND header. V4.1 clients are found using the sessionID in the CB_SEQUENCE operation which is also compared against the sessionID associated with the back channel thread after a successful CREATE_SESSION. Each of these methods finds the one an only nfs_client associated with the incoming callback request - so nfs_find_client_next is not needed. In the RPC layer, the pg_authenticate call needs to find the nfs_client. For the v4.0 callback service, the callback identifier has not been decoded so a search by address, version, and minorversion is used. The sessionid for the sessions based callback service has (usually) not been set for the pg_authenticate on a CB_NULL call which can be sent prior to the return of a CREATE_SESSION call, so the sessionid associated with the back channel thread is not used to find the client in pg_authenticate for CB_NULL calls. Pass the referenced nfs_client to each CB_COMPOUND operation being proceesed via the new cb_process_state structure. The reference is held across cb_compound processing. Use the new cb_process_state struct to move the NFS4ERR_RETRY_UNCACHED_REP processing from process_op into nfs4_callback_sequence where it belongs. Signed-off-by: Andy Adamson <andros@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
81 lines
2.4 KiB
C
81 lines
2.4 KiB
C
/******************************************************************************
|
|
|
|
(c) 2008 NetApp. All Rights Reserved.
|
|
|
|
NetApp provides this source code under the GPL v2 License.
|
|
The GPL v2 license is available at
|
|
http://opensource.org/licenses/gpl-license.php.
|
|
|
|
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
|
|
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
|
|
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
|
|
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
|
|
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
******************************************************************************/
|
|
|
|
/*
|
|
* Functions to create and manage the backchannel
|
|
*/
|
|
|
|
#ifndef _LINUX_SUNRPC_BC_XPRT_H
|
|
#define _LINUX_SUNRPC_BC_XPRT_H
|
|
|
|
#include <linux/sunrpc/svcsock.h>
|
|
#include <linux/sunrpc/xprt.h>
|
|
#include <linux/sunrpc/sched.h>
|
|
|
|
#ifdef CONFIG_NFS_V4_1
|
|
struct rpc_rqst *xprt_alloc_bc_request(struct rpc_xprt *xprt);
|
|
void xprt_free_bc_request(struct rpc_rqst *req);
|
|
int xprt_setup_backchannel(struct rpc_xprt *, unsigned int min_reqs);
|
|
void xprt_destroy_backchannel(struct rpc_xprt *, int max_reqs);
|
|
int bc_send(struct rpc_rqst *req);
|
|
|
|
/*
|
|
* Determine if a shared backchannel is in use
|
|
*/
|
|
static inline int svc_is_backchannel(const struct svc_rqst *rqstp)
|
|
{
|
|
if (rqstp->rq_server->bc_xprt)
|
|
return 1;
|
|
return 0;
|
|
}
|
|
static inline struct nfs4_sessionid *bc_xprt_sid(struct svc_rqst *rqstp)
|
|
{
|
|
if (svc_is_backchannel(rqstp))
|
|
return (struct nfs4_sessionid *)
|
|
rqstp->rq_server->bc_xprt->xpt_bc_sid;
|
|
return NULL;
|
|
}
|
|
|
|
#else /* CONFIG_NFS_V4_1 */
|
|
static inline int xprt_setup_backchannel(struct rpc_xprt *xprt,
|
|
unsigned int min_reqs)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int svc_is_backchannel(const struct svc_rqst *rqstp)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline struct nfs4_sessionid *bc_xprt_sid(struct svc_rqst *rqstp)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
static inline void xprt_free_bc_request(struct rpc_rqst *req)
|
|
{
|
|
}
|
|
#endif /* CONFIG_NFS_V4_1 */
|
|
#endif /* _LINUX_SUNRPC_BC_XPRT_H */
|
|
|