lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: brcm80211: fix rtnl_lock issue when bringing down brcmfmac

Browse Source 
When bringing down the netdevice interface a deadlock occurred
sporadically due to the rtnl_lock being held by a task that was
waiting for another task trying to get the lock. This patch fixes
that issue.

Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Arend van Spriel
2011-08-23 14:13:57 +02:00
committed by Greg Kroah-Hartman
parent 60be7ec509
commit 183eeb985a
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
View File

@@ -3189,7 +3189,14 @@ static void brcmf_term_iscan(struct brcmf_cfg80211_priv *cfg_priv)
if (cfg_priv->iscan_on && iscan->tsk) {
iscan->state = WL_ISCAN_STATE_IDLE;
send_sig(SIGTERM, iscan->tsk, 1);
/*
* The iscan task may want to acquire the rtnl_lock
* so release it here upon stopping the task.
*/
rtnl_unlock();
kthread_stop(iscan->tsk);
rtnl_lock();
iscan->tsk = NULL;
/* Abort iscan running in FW */