lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ftrace: printk and trace irqsoff and wakeups

Browse Source 
printk called from wakeup critical timings and irqs off can
cause deadlocks since printk might do a wakeup itself. If the
call to printk happens with the runqueue lock held, it can
deadlock.

This patch protects the printk from being called in trace irqs off
with a test to see if the runqueue for the current CPU is locked.
If it is locked, the printk is skipped.

The wakeup always holds the runqueue lock, so the printk is
simply removed.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Steven Rostedt 2008-05-12 21:20:54 +02:00 committed by Thomas Gleixner
parent 8f96da02c1
commit 4fe8c3048c
2 changed files with 14 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
kernel/trace/trace_irqsoff.c
View File

@ -165,18 +165,20 @@ check_critical_timing(struct trace_array *tr,
update_max_tr_single(tr, current, cpu);
if (tracing_thresh) {
printk(KERN_INFO "(%16s-%-5d|#%d):"
" %lu us critical section violates %lu us threshold.\n",
current->comm, current->pid,
raw_smp_processor_id(),
latency, nsecs_to_usecs(tracing_thresh));
} else {
printk(KERN_INFO "(%16s-%-5d|#%d):"
" new %lu us maximum-latency critical section.\n",
current->comm, current->pid,
raw_smp_processor_id(),
latency);
if (!runqueue_is_locked()) {
if (tracing_thresh) {
printk(KERN_INFO "(%16s-%-5d|#%d): %lu us critical"
" section violates %lu us threshold.\n",
current->comm, current->pid,
raw_smp_processor_id(),
latency, nsecs_to_usecs(tracing_thresh));
} else {
printk(KERN_INFO "(%16s-%-5d|#%d): new %lu us"
" maximum-latency critical section.\n",
current->comm, current->pid,
raw_smp_processor_id(),
latency);
}
}
max_sequence++;

13
kernel/trace/trace_sched_wakeup.c
View File

@ -106,19 +106,6 @@ wakeup_sched_switch(struct task_struct *prev, struct task_struct *next)
update_max_tr(tr, wakeup_task, wakeup_cpu);
if (tracing_thresh) {
printk(KERN_INFO "(%16s-%-5d|#%d):"
" %lu us wakeup latency violates %lu us threshold.\n",
wakeup_task->comm, wakeup_task->pid,
raw_smp_processor_id(),
latency, nsecs_to_usecs(tracing_thresh));
} else {
printk(KERN_INFO "(%16s-%-5d|#%d):"
" new %lu us maximum wakeup latency.\n",
wakeup_task->comm, wakeup_task->pid,
cpu, latency);
}
out_unlock:
__wakeup_reset(tr);
spin_unlock_irqrestore(&wakeup_lock, flags);