lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

writeback: fix bad _bh spinlock nesting

Browse Source 
Fix a bug where a lock is _bh nested within another _bh lock,
but forgets to use the _bh variant for unlock.

Further more, it's not necessary to test _bh locks, the inner lock
can just use spin_lock(). So fix up the bug by making that change.

Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
This commit is contained in:
Jens Axboe 2010-08-04 13:34:31 +02:00
parent e7f52dfb4f
commit 6bf05d03ea
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mm/backing-dev.c
View File

@ -415,7 +415,8 @@ static int bdi_forker_thread(void *ptr)
break;
}
spin_lock_bh(&bdi->wb_lock);
spin_lock(&bdi->wb_lock);
/*
* If there is no work to do and the bdi thread was
* inactive long enough - kill it. The wb_lock is taken
@ -432,7 +433,7 @@ static int bdi_forker_thread(void *ptr)
action = KILL_THREAD;
break;
}
spin_unlock_bh(&bdi->wb_lock);
spin_unlock(&bdi->wb_lock);
}
spin_unlock_bh(&bdi_lock);