lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: brcm80211: bugfix for fifo problem on 64 bits platforms.

Browse Source 
Message 'receive fifo overflow' appeared in the log. Root cause was an
invalid physical address being programmed into the DMA engine. This was
caused by an invalid pointer cast in the dma code. Issue was observed on
a Sparc (Sun Fire V120) machine but could theoretically also pop up
on other architectures.

Driver was tested to scan and ping on aforementioned machine.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Roland Vossen
2011-08-23 14:13:59 +02:00
committed by Greg Kroah-Hartman
parent 49d468f64d
commit c13d2ad059
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/brcm80211/brcmsmac/dma.c
View File

@@ -600,13 +600,18 @@ static bool _dma_alloc(struct dma_info *di, uint direction)
void *dma_alloc_consistent(struct pci_dev *pdev, uint size, u16 align_bits,
uint *alloced, unsigned long *pap)
{
void *rc;
dma_addr_t dma_addr;
if (align_bits) {
u16 align = (1 << align_bits);
if (!IS_ALIGNED(PAGE_SIZE, align))
size += align;
*alloced = size;
}
return pci_alloc_consistent(pdev, size, (dma_addr_t *) pap);
rc = pci_alloc_consistent(pdev, size, &dma_addr);
*pap = dma_addr;
return rc;
}
/* !! may be called with core in reset */