Commit Graph

174502 Commits

Author SHA1 Message Date
Klaas van Gend
a8c5c198c7 Staging: comedi: drivers: ni_6527: fixup checkpatch.pl warnings
This patch fixes all warnings as issued by checkpatch.pl.
Note that I had to modify some of the logging messages to make that possible.

Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Klaas van Gend
d62a01d861 Staging: comedi: comedi_fc: checkpatch.pl fixes
This patch fixes all warnings as issued by checkpatch.pl.

Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Kevyn-Alexandre Paré
a69fba9e37 Staging: comedi: pcl726: fix coding style issues
Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Roel Kluin
dc8af06898 Staging: comedi: addi-data: Cleanup redundant tests on unsigned
The variables are unsigned so the test `>= 0' is always true,
In these cases the other part of the test catch wrapped values.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Klaas van Gend
c5dba43b60 staging: comedi: multiq3: add KERN_
Add KERN_ to printk statements to reduce the number of warnings
shown by checkpatch.pl.

Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Klaas van Gend
446176a743 staging: comedi: multiq3: remove warning on braces
Remove braces in if statements to make the file exhibit less warnings
when checked using checkpatch.pl.

Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
BRAGA, Bruno
bacf58a803 Staging: comedi: adl_pci8164 coding style fixes
Corrected coding style:
- excessive curly braces
- printk without KERN_* logging
- 80+ chars per line of code

Signed-off-by: BRAGA, Bruno <bruno.braga@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Shawn Bohrer
d1babfd466 Staging: comedi: remove EXTERN macro since it is not used
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Shawn Bohrer
37a110c049 Staging: comedi: remove __cplusplus check
c++ isn't supported in the kernel.

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:02 -08:00
Shawn Bohrer
a6279bc9e4 Staging: comedi: Don't check for -ENOIOCTLCMD
unlocked_ioctl() never returns -ENOIOCTLCMD so remove the check.

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:01 -08:00
Shawn Bohrer
5d7ae22554 Staging: comedi: remove check for HAVE_COMPAT_IOCTL
All new kernels have support for compat_ioctl so remove the check and support
for older kernels.

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:01 -08:00
Shawn Bohrer
00a1855c21 staging: comedi: Remove check for HAVE_UNLOCKED_IOCTL
All new kernels have unlocked_ioctl so we don't need to check.

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:01 -08:00
Daniel Patrick Johnson
013f230c4f Staging: comedi: pcmmio: more coding style cleanup
Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:01 -08:00
Daniel Patrick Johnson
d2d08955e7 Staging: comedi: pcmmio: Coding style cleanup
Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:01 -08:00
Daniel Patrick Johnson
22d89f4abf Staging: Comedi: pcm_common: Fixed all checkpatch issues
Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:23:01 -08:00
Daniel Patrick Johnson
b055d0d3c7 Staging: comedi: ni_mio_cs.c: coding style cleanup
Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:51 -08:00
Dirk Hohndel
828684f9a6 Staging: comedi: trivial fix of a very frequent spelling mistake
something-bility is spelled as something-blity so a grep for 'blit'
would find these lines

this is so trivial that I didn't split it by subsystem / copy additional
maintainers - all changes are to comments The only purpose is to get
fewer false positives when grepping around the kernel sources.

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:51 -08:00
Kevyn-Alexandre Paré
56f5f24d1b Staging: comedi: amplc_pc263.c: more coding style fixes
Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:51 -08:00
Kevyn-Alexandre Paré
abdedefed7 Staging: comedi: amplc_pc263.c: fix coding style issues
Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:51 -08:00
Bruce Jones
ff492d38ba Staging: comedi: adl_pci7432: coding style cleanup
Correct coding style problems in this file.

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:51 -08:00
Bruce Jones
1ab1774f12 Staging: comedi: adl_pci7296: CodingStyle cleanup
Fix up printk's and other simple coding style issues.

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Bruce Jones
0dfd69bfdb Staging: comedi: acl7225b.c: CodingStyle printk fixups
Clean up the printk's in this driver.

Signed-off-by: Bruce Jones <brucej@linux.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Shane Warden
2829db3eec Staging: comedi: comedi_compat32.h: Fixed checkpatch.pl issues
Signed-off-by: Shane Warden <shane.warden@onyxneon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Bruce Jones
6dd60bc629 Staging: comedi: vmk80xx: cleanup formatting
Clean up formatting of a struct initializer, as per the
standard conventions.

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Bruce Jones
3c9cd618b9 Staging: comedi: ni_atmio16d: printk fixups
Fix improper use of printks in this driver.  Most are
debug messages under a DEBUG #ifdef, a few are info/warnings
that should get logged for driver error conditions.

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Bruce Jones
ce5ade4f74 Staging: comedi: nt_atmio16d: space and tab fixes
Turn spaces into tabs to keep scripts/checkpatch.pl happy.  The
actual changes here are in a comment, so the script is just
being silly.

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Bruce Jones
988da29c48 Staging: comedi: ni_atmio16d: brace fixes
Fix improper use of braces in drivers/staging/comedi/drivers/ni_atmio16d.c

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
Bruce Jones
2c146810e3 Staging: comedi: ni_atmio16d: fix formating errors
Correct formatting errors - in this case line length and spaces before
parens.

Signed-off-by: Bruce Jones <brucej@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
matt mooney
120be77b88 Staging: comedi: mite.h: deletion of unused functions
drivers/mite.h: removed declared but undefined functions mite_ll_from_kvmem
and mite_setregs

Signed-off-by: matt mooney <mfm@muteddisk.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:50 -08:00
matt mooney
5256fb8818 Staging: comedi: mite.c: fix coding style
- drivers/mite.c: added KERN_ facility level to printk
 - moved EXPORT_SYMBOL macro to follow function/variable

Signed-off-by: matt mooney <mfm@muteddisk.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Allison Randal
d1a044083c Staging: comdi: ni_at_ao.c: fix coding style error
The line was too long, used braces on single line for loop body.

Signed-off-by: Allison Randal <allison@parrot.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Shane Warden
62eeae9308 Staging: comedi: comedidev.h: Fixed checkpatch.pl issues
Signed-off-by: Shane Warden <shane.warden@onyxneon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Shane Warden
f36624369f Staging: comedi: comedi_compat32: Fixed checkpatch.pl issues
Signed-off-by: Shane Warden <shane.warden@onyxneon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Bart Massey
63a4eca57c Staging: comedi: ni_labpc_cs: wrapped long comments
Signed-off-by: Bart Massey <bart@cs.pdx.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Bart Massey
92c4bad75c Staging: comedi: ni_labpc_cs: removed null check from kfree
Signed-off-by: Bart Massey <bart@cs.pdx.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Bart Massey
962331810f Staging: comedi: ni_labpc_cs: removed null initialization of static
Signed-off-by: Bart Massey <bart@cs.pdx.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Bart Massey
b79eb4c113 Staging: comedi: ni_labbc_cs: cleaned up debug define a bit
Signed-off-by: Bart Massey <bart@cs.pdx.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:49 -08:00
Shane Warden
8642fc4e2b Staging: comedi: ni_labpc.h: Fixed line lengths of some trailing comments.
Signed-off-by: Shane Warden <shane.warden@onyxneon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:48 -08:00
Vlatko Kosturjak
becdaa83c4 Staging: comedi: adl_pci6208: code styling fix
Fix a checkpatch.pl errors.

Signed-off-by: Vlatko Kosturjak <kost@linux.hr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:48 -08:00
Mithlesh Thukral
d43d27abf7 Staging: comedi: drivers.c: checkpatch fix
Fix a checkpatch.pl error. Fix struct * foo to struct *foo

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:48 -08:00
Ben Kero
228ec34021 Staging: comedi: 8255: Fix coding style error
EXPORT_SYMBOL's in the wrong place.  Unnecessary {}s

Signed-off-by: Ben Kero <ben.kero@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:48 -08:00
Greg Kroah-Hartman
155b44aae0 Staging: comedi: 8253: fix coding style error
The line was too long.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:48 -08:00
Shawn Bohrer
334a33d810 staging: line6: Convert simple_strtoul to strict_strtoul in midi.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:48 -08:00
Shawn Bohrer
7e4d5c13d8 staging: line6: Convert simple_strtoul to strict_strtoul in pod.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00
Shawn Bohrer
c0e6e7c1b2 staging: line6: Convert simple_strtoul to strict_strtoul in variax.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00
Shawn Bohrer
bb950a169d staging: line6: Convert simple_strtol to strict_strtol in toneport.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00
Shawn Bohrer
63a4a8bad9 staging: line6: Lindent and fix some checkpatch warnings in toneport.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00
Shawn Bohrer
afb9091dd3 staging: line6: Fix checkpatch warnings in pcm.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00
Shawn Bohrer
49da3dd935 staging: line6: Convert simple_strtoul() to strict_strtoul in control.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00
Shawn Bohrer
2a20bf6f1a staging: line6: Fix some checkpatch warnings in control.c
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11 12:21:47 -08:00